Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add add_attributes serializer #139

Merged
merged 16 commits into from
Jan 29, 2025
Merged

feat: Add add_attributes serializer #139

merged 16 commits into from
Jan 29, 2025

Conversation

ewuerger
Copy link
Member

Added layer custom field to generic and diagram serializer.

@ewuerger
feat: Add layer custom field
64d0692 
Added `layer` custom field to generic and diagram serializer.
@ewuerger ewuerger force-pushed the add-layer-and-nature branch 2 times, most recently from 182ce81 to fa8ffa6 Compare December 12, 2024 16:39
@ewuerger ewuerger force-pushed the add-layer-and-nature branch from fa8ffa6 to ee26a4f Compare December 12, 2024 16:41
@ewuerger
feat(serializer): Add add_attributes serializer
fac3949 
For now this serializer is only supports adding
enum attributes as custom fields.
@ewuerger ewuerger changed the title feat: Add layer custom field feat: Add add_attributes serializer Dec 13, 2024
@ewuerger ewuerger force-pushed the add-layer-and-nature branch 2 times, most recently from 942c312 to 53a7186 Compare December 13, 2024 15:22
@ewuerger ewuerger force-pushed the add-layer-and-nature branch from 53a7186 to 20da2f4 Compare December 13, 2024 15:24
@ewuerger ewuerger requested a review from micha91 December 13, 2024 15:27
@ewuerger ewuerger self-assigned this Dec 13, 2024
@ewuerger ewuerger added documentation Improvements or additions to documentation enhancement New feature or request labels Dec 13, 2024
micha91
micha91 reviewed Dec 17, 2024
View reviewed changes
Copy link
Collaborator

@micha91 micha91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review not finished yet, but I wanted to provide you with the first feedback asap

capella2polarion/converters/model_converter.py Show resolved Hide resolved
capella2polarion/converters/element_converter.py Outdated Show resolved Hide resolved
capella2polarion/converters/element_converter.py Outdated Show resolved Hide resolved
capella2polarion/converters/element_converter.py Show resolved Hide resolved
capella2polarion/converters/element_converter.py Outdated Show resolved Hide resolved
capella2polarion/converters/element_converter.py Outdated Show resolved Hide resolved
@ewuerger
feat: Enable serializers for * section
71af412 
Also make `layer` custom field configurable from config instead of built-in.
@ewuerger ewuerger force-pushed the add-layer-and-nature branch 6 times, most recently from 3de39bd to 693b8d1 Compare January 6, 2025 10:02
@ewuerger ewuerger force-pushed the add-layer-and-nature branch from 693b8d1 to a49cb47 Compare January 6, 2025 10:08
micha91
micha91 requested changes Jan 10, 2025
View reviewed changes
Copy link
Collaborator

@micha91 micha91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would recommend to do some more refactoring in the converter_config. In addition to that just small things

capella2polarion/converters/converter_config.py Outdated Show resolved Hide resolved
capella2polarion/converters/converter_config.py Outdated Show resolved Hide resolved
capella2polarion/converters/converter_config.py Outdated Show resolved Hide resolved
capella2polarion/converters/element_converter.py Outdated Show resolved Hide resolved
capella2polarion/converters/element_converter.py Show resolved Hide resolved
capella2polarion/converters/element_converter.py Outdated Show resolved Hide resolved
capella2polarion/data_model/work_item_attachments.py Show resolved Hide resolved
@ewuerger ewuerger force-pushed the add-layer-and-nature branch from 9759b78 to f9e9b03 Compare January 23, 2025 15:07
ewuerger
ewuerger commented Jan 23, 2025
View reviewed changes
Copy link
Member Author

@ewuerger ewuerger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is resolved I think. Looking forward to the final review.

capella2polarion/converters/element_converter.py Outdated Show resolved Hide resolved
@ewuerger ewuerger requested a review from micha91 January 27, 2025 09:50
micha91
micha91 approved these changes Jan 29, 2025
View reviewed changes
Copy link
Collaborator

@micha91 micha91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
We just need to mention the change of the serializer collection in the release notes

capella2polarion/converters/converter_config.py Show resolved Hide resolved
@ewuerger ewuerger merged commit 480e7af into main Jan 29, 2025
9 checks passed
@ewuerger ewuerger deleted the add-layer-and-nature branch January 29, 2025 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wuestengecko Wuestengecko Wuestengecko left review comments

@micha91 micha91 micha91 approved these changes

Assignees

@ewuerger ewuerger

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ewuerger @Wuestengecko @micha91