Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changed song #50

Merged
merged 3 commits into from
Oct 11, 2024
Merged

changed song #50

merged 3 commits into from
Oct 11, 2024

Conversation

bibimbop123
Copy link
Contributor

No description provided.

merrillhuang
merrillhuang approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@merrillhuang merrillhuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like change shouldn't break anything.

@bibimbop123 bibimbop123 requested review from dsimp and jessjno October 11, 2024 21:28
jessjno
jessjno reviewed Oct 11, 2024
View reviewed changes
Copy link
Contributor

@jessjno jessjno left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you forgot to add your p element

@bibimbop123
Copy link
Contributor Author

bibimbop123 commented Oct 11, 2024 •
edited
Loading

I think you forgot to add you p element

didn't realize you had to have that. interesting

@bibimbop123 bibimbop123 requested a review from jessjno October 11, 2024 21:38
jessjno
jessjno approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@jessjno jessjno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@bibimbop123 bibimbop123 merged commit 39165e7 into main Oct 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merrillhuang merrillhuang merrillhuang approved these changes

@jessjno jessjno jessjno approved these changes

@BlueUnderBoy BlueUnderBoy Awaiting requested review from BlueUnderBoy

@tluu5 tluu5 Awaiting requested review from tluu5

@AnnaVi11arrea1 AnnaVi11arrea1 Awaiting requested review from AnnaVi11arrea1

@dsimp dsimp Awaiting requested review from dsimp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bibimbop123 @jessjno @merrillhuang