Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Disable optimization to avoid pontential errors #640

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

howjmay
Copy link
Collaborator

@howjmay howjmay commented Jun 26, 2024

Some function may be ignored or not well executed if optimization is applied. A classic example is test test_mm_set_rounding_mode.

_mm_round_ps is computed in compiling time, in which case, rounding mode changing is ignored.

@howjmay
Copy link
Collaborator Author

howjmay commented Jun 26, 2024

relates to #635

sse2neon.h Outdated Show resolved Hide resolved
@howjmay
Copy link
Collaborator Author

howjmay commented Jun 26, 2024

Another question.
Should we add another option for developers to disable forced not optimized attributes here?

@jserv
Copy link
Member

jserv commented Jun 26, 2024

Another question. Should we add another option for developers to disable forced not optimized attributes here?

I found no reason to disable forced not optimized attributes. Can you enumerate the considerations?

@howjmay
Copy link
Collaborator Author

howjmay commented Jun 26, 2024

The error we met this time happened when the rounding mode is changed, and the input is given in compiled time.
Not sure if there will be the use case that the input is given and the rounding mode is unchanged, then the original implementation will be faster. Considering about the input data should be given, it should be a rare case

Some function may be ignored or not well executed if optimization is
applied. A classic example is test test_mm_set_rounding_mode.

_mm_round_ps is computed in compiling time, in which case, rounding mode changing is ignored.
@howjmay howjmay marked this pull request as ready for review June 26, 2024 09:05
@howjmay howjmay requested a review from marktwtn as a code owner June 26, 2024 09:05
@jserv jserv merged commit 6f2ea55 into DLTcollab:master Jun 26, 2024
16 checks passed
@howjmay howjmay deleted the disable-opt branch June 26, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants