-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
970 make tiglwinginterpolatexsi work on a single segment that is not part of a component segment #979
Conversation
…of a component segment - make unittest WinInterpolateXsi work
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #979 +/- ##
==========================================
+ Coverage 68.75% 68.94% +0.18%
==========================================
Files 299 299
Lines 26481 26509 +28
==========================================
+ Hits 18208 18277 +69
+ Misses 8273 8232 -41
|
…see if the segment referred to in the argument is contained in the given wing component segment.
…efer to the same wing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @AntonReiswich. I just have some minor review comments.
tests/unittests/TestData/test_wing_segment_special_without_component_segments.xml
Outdated
Show resolved
Hide resolved
Update date in unittest comment Co-authored-by: Jan Kleinert <[email protected]>
delete commented out line Co-authored-by: Jan Kleinert <[email protected]>
delete empty code blocks Co-authored-by: Jan Kleinert <[email protected]>
…t-that-is-not-part-of-a-component-segment' of https://github.com/DLR-SC/tigl into 970-make-tiglwinginterpolatexsi-work-on-a-single-segment-that-is-not-part-of-a-component-segment
Thanks a lot for the code review! |
Description
In order to fix #970, the function tiglWingInterpolateXsi has been generalized. The generalization allows to not only use the function for segments that are not contained in a component segment (c.f. #970), but also more generally. Consider the following illustration that demonstrates the generality in which tiglWingInterpolateXsi can be used now:
Assume the depicted wing has four segments S1, S2, S3 and S4 and two component segments CS_A and CS_B.
The three arguments of the function firstUID, secondUID, intersectionUID can be now chosen (to give only few exapmles) in the following way:
More precisely: firstUID, secondUID, intersectionUID can be either a segment or component segment, respectively. The segments don't necessarily need to belong to a component segment. The component segments refered by the UIDs don't need to be the same. The only restriction is that all segments or component segments refered by the three UIDs are part of one and the same wing. If the intersection if outside the segment or component segment refered by intersectionUID an error gets thrown, as for example if one chooses S3, S4, S1.
How Has This Been Tested?
New test data (test_wing_segment_special_modified_component_segments.xml) has been added together with unittests in WingInterpolateXsi to check new functionalities that on the one hand show that the bug in issue #970 is fixed and on the other hand to check the functionalities that came with generalizing the function even further.
Checklist:
[ ] New classes have been added to the Python interface.