Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CCPACSSkin to Python bindings #1041

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

Add CCPACSSkin to Python bindings #1041

wants to merge 7 commits into from

Conversation

joergbrech
Copy link
Contributor

@joergbrech joergbrech commented Dec 3, 2024

Fixes #1037

Description

This PR adds the missing#include and %include statements to the swig interface file configuration.i.

How Has This Been Tested?

Screenshots, that help to understand the changes(if applicable):

Not applicable.

Checklist:

Task Finished Reviewer Approved
At least one test for the new functionality was added.
  • yes
  • does not apply
  • OK
New classes have been added to the Python interface.
  • yes
  • does not apply
  • OK
The code is properly documented with doxygen docstrings
  • yes
  • does not apply
  • OK
Changes are documented at the top of ChangeLog.md
  • yes
  • does not apply
  • OK

Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 69.47%. Comparing base (c5ccbb2) to head (9281d66).
Report is 38 commits behind head on master.

Files with missing lines Patch % Lines
src/fuselage/CTiglStringerFrameBorderedObject.cpp 0.00% 12 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1041   +/-   ##
=======================================
  Coverage   69.47%   69.47%           
=======================================
  Files         301      301           
  Lines       26889    26923   +34     
=======================================
+ Hits        18681    18705   +24     
- Misses       8208     8218   +10     
Flag Coverage Δ
unittests 69.47% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/fuselage/CTiglStringerFrameBorderedObject.cpp 0.00% <0.00%> (ø)

... and 4 files with indirect coverage changes

@joergbrech joergbrech marked this pull request as draft January 2, 2025 10:31
@merakulix
Copy link
Contributor

Short update: CCPACSkin is available now via Python Bindings, CPACSSkinSegments as well. I also tested some of the getter functions of boost::optional types in CCPACSFuselageStructure, such as stringers, frames, cargo_cross_beams, cargo_cross_beam_struts, which are also available now. As discussed with @joergbrech, see RISCSoftware/cpacs_tigl_gen#59 about the getter functions for the vector elements

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Several fuslage python bindings seem to be broken
2 participants