Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vitalium: Notify host of changed parameters on patch load. #131

Merged
merged 1 commit into from
May 1, 2024

Conversation

DarkRTA
Copy link
Contributor

@DarkRTA DarkRTA commented Apr 17, 2024

This fixes #96 as far as I am aware.

@DarkRTA DarkRTA force-pushed the vitalium-save-fix branch 3 times, most recently from 9448350 to 53f330f Compare April 18, 2024 00:31
@xard-dev
Copy link

xard-dev commented Apr 27, 2024

I tested the nightly build and can confirm that this pull request solved the issue #96 I was experiencing with various software with the LV2 version of Vitalium.

@falkTX
Copy link
Contributor

falkTX commented Apr 27, 2024

logic looks good to me, but the syntax is very odd.
please change

auto old_values = std::map<std::string, float>(); to just std::map<std::string, float> old_values;

and for (auto i = controls_.begin(); i != controls_.end(); i++) { to for (const auto& it : controls_) {

thanks!

@DarkRTA
Copy link
Contributor Author

DarkRTA commented Apr 28, 2024

I am currently out on vacation and won't be able to fix this for a few days.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@DarkRTA DarkRTA force-pushed the vitalium-save-fix branch from f32149b to bd2c320 Compare April 30, 2024 23:40
@DarkRTA
Copy link
Contributor Author

DarkRTA commented Apr 30, 2024

this should be good now. found some downtime to go ahead and do this

@falkTX
Copy link
Contributor

falkTX commented May 1, 2024

thanks! will merge now then

@falkTX falkTX merged commit b3596e6 into DISTRHO:master May 1, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LV2 Vitalium settings do not restore correctly when a project is saved and reopened
3 participants