Temp/embargo and tests wip

[EdoStorm96]

Make tests pass :)

Just some final issues to ensure major/4 can pass tests ...

Besides the stuff you did already, I made the PreAss and PreAppr proposals use the test_pdf.pdf file, when applicable, and solved the issue with adding a WMO object to PreAss proposals in the test db.

PS. I am not quite sure what self.wmo on line 80 of proposal_submission_tests.py is doing now ... As I don´t see it being referenced anywhere ... But I tried removing it and it broke the tests ...

[miggol]

Approved with some minor requests.

[miggol]

I think I intended to add a comment along the lines of

"we save this variable for later, but want it set for None for this part of the validation"

Because as it stands this is kind of confusing.

[miggol]

This wmo must be implicitly getting used for the regular self.proposal.wmo without getting explicitly assigned. I don't know why (it's very confusing), but perhaps it would be better to add self.proposal.wmo = self.wmo down here:

    def setup_proposal(self):
        """
        Load our test proposals from a fixture, then add our user as
        an applicant to each of them.

        Please note, this currently uses a mish-mash of both fixtures
        and programmatically created users and objects.
        """
        self.wmo = Wmo(
            status=0,
            metc="N",
            is_medical="N",
        )
        self.wmo.save()
        self.proposal = Proposal.objects.get(pk=1)
        self.proposal.applicants.add(self.user)
        self.proposal.wmo = self.wmo
        self.proposal.save()

Right before the proposal gets saved. Just to make it explicit and less magic.