fix: avoid double validation of submit form #834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miggol
approved these changes
Jan 7, 2025
proposals/forms.py
Outdated
| if form_errors: | ||
| # If there are only errors on the submit form, we override this | ||
| # validation. Otherwise saving the updated data becomes impossible | ||
| if len(form_errors) == 1 and form_errors[0]["page_name"] == _("Indienen"): |
There was a problem hiding this comment.
Works surprisingly well, but I would much rather have a test like
"proposals/submit" in error["url"].lower()"The URL just feels a lot more dependable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, the fix you suggested, @miggol:
When validating the submit form using the stepper, if only the submit form has an error, we don't add an extra error, as this can cause the form to get stuck, because it is unable to save.
Nothing fancy.
This does kindoff showcase why having
Stepper.get_form_errors()return a list of dicts was a bit of a bad idea ... my bad hehe