Fix/textual bugs #833
Merged
Fix/textual bugs #833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miggol
approved these changes
Jan 6, 2025
Comment on lines
+839
to
+841
| self.fields["inform_local_staff"].label = self.fields[ | ||
| "inform_local_staff" | ||
| ].label |
There was a problem hiding this comment.
For me, this part is not necessary to fix the bug.
But it's also harmless.
There was a problem hiding this comment.
The same goes for the other_stakeholders part, which never gave us any trouble. I have no rational reasoning but feel like keeping it in just to be safe.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #829
So this fixes two bugs.
The homepage trans tags:
Djlint made the html inside the trans tags multi-line, so it required blocktrans tags.
the inform_local_staff label:
So ... the big one. I had a closer look at how another label was marked safe, namely
other_stakeholders... I've just gone and implemented this the same way. It is really ugly ... but it does work (for now ... seemingly ...), which is nice at this point!So basically, you just override the label in the form and mark it safe there. This means this label exists in two places. The label in the model is just there for reference. This kinda sucks, but I guess this is how we did it before?
I found that the
other_stakeholderslabel in the form wasmark_safe'd twice, which AFAICT is redundant, so I removed this.Let me know what you think :)