Merge 4.0-rc1 into develop #827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and_secretary_pages_redesign Feature/review and secretary pages redesign
…_refinement Feature/stepper refinement
* feat: make legacy docs optional in pdf * feat: reorganize pdf_diff_stuff * fix: more reorganizing code * fix: weird unrelated bug that was in here ... * feat: implement PersonalDataSection * fix: reorganize back * feat: create TitleSection helper * feat: add new attachments to the pdf (sloppily) * feat: renaming and reoirdering some sections * feat: make a class for Attachment Sections pdf * fix: bug with how sessions are fetched for diff * feat: ensure handle_attachment can recognize revised attachment * feat: create all sections for diff * feat: remove all support for legacy docs * feat: add verbose_name to Attachment.name & comments * feat: add all documents titlesection * feat: add all documents title section to diff * black * black * feat: recursive AllAttachmentsSectionsDiff * feat: docstrings * style: black * fix: remove rogue old_docs stuff * style: black whitespace * style: another black whitespace * feat: implement logic for nonstandard proposals * fix: some nonsense in AttachmentSection. * fix: bugfix in _match_slot * fix: stateful consistency * style: black djlint * add upload date to AttachmentSection * style: black * fix: remove "gewijzigd voor revisie" text * feat: improve margins and do away with TitleSection * fix: duplication bug * fix: redo conflicting migrations * i18n: Translations * feat: Change attachment field order in diff and pdf --------- Co-authored-by: Michael Villeneuve <[email protected]>
Brings new email templates into major/4. Required a small migrations fix
* fix: Embargo KeyError * style
Fix/textual bugs
…d_tests_wip Temp/embargo and tests wip
…dation_bug fix: avoid double validation of submit form
* feat: Import code from old branch to avoid merge * wip: Working on attachments in new branch * fix: Mishmash of migrations * wip: Various fixes for attachments * feat: Attachment renderable templates & updates * feat: Change var name and minor changes * feat: Verbose name for Attachment.upload * feat: Attachment views * feat: Attachment form template * wip: Minor changes * feat: Add author field to Attachment * feat: Classmethod to initialize kind from an attachment * feat: Provide manager object to children * feat: Download view for attachments * feat: Break out BaseAttachFormView to make attachment edit view * fix: Move classes around to prevent circular imports * wip: Remove attachments manager for now * feat: Initialize stepper outside of context-getting * wip: Start managing attachments by Checkers * feat: Make sure slots know what they're attaching to * fix: Minor fixes and comment updates * cleanup: Remove old code and simplify object getting * feat: Just fill in study slots by hand for now * feat: Detach functionality for Attachments * feat: Get Attachment subclasses without kind * feat: Make slots less dependent on kinds * feat: Detach view and links, editing flag for AttachFormView * feat: Extra/optional attachments with DMP example * feat: New desiredness flags * feat: New add_slot method * feat: Template enhancements and cleanup * style: Black * style: djlint * add cdh_files/ to .gitignore * fix: create and implement attachment filename generator * feat: proper implementation of filename generator * fix: bug in Study.research_settings_contains_schools * fix: Remove FnGen from model * feat: Auto retrieve Kind from attachment if none provided * feat: Classmethod to get a slot from a proposal * wip: Get filename from slot instead of kind * feat: Rename and finalize generate_filename() function * feat: Point methods in right direction * style * feat: Custom fn_part for kinds * feat: Add order variable for Slots and FnGen * fix: Turn get_fn_part into classmethod * fix: Kind derivation for empty slot matching * fix: Delete anachronistic migration * feat: Functions to enumerate slots * feat: Template changes to display normalized filename after <br /> * feat: Download filenames in PDF and DIFF are now the normalized versions * style * Feat/fetc filename in pdf (#837) * feat: create custom attachment row * feat: make us of the custom attachment row * style: black * fix: Prevent collapsing of value in PDF * fix: Hyphenate kind in fetc filename * fix: Merge accident, double return statement * fix: Actually implement stepper.filled_slots * fix: We can't assume all owners are represented in att_dict --------- Co-authored-by: Edo Storm <[email protected]> Co-authored-by: Edo Storm <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From this merge onwards, fetc.tst will start tracking develop again.
The following fixtures need to be reloaded: