Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/archive access bug #821

Merged
merged 4 commits into from
Dec 16, 2024
Merged

Fix/archive access bug #821

merged 4 commits into from
Dec 16, 2024

Conversation

EdoStorm96
Copy link
Contributor

fixes #815.

A small PR for a change ;p

The mixin used for archive access check HumanitiesOrPrivilegeRequiredMixin was not raising a PermissionDenied. It's default behaviour is to ask for login again (which apparently was also not working on the test server). This is now fixed.

The archive button is also removed from the homepage if the user cannot access it.

@EdoStorm96 EdoStorm96 requested a review from miggol December 16, 2024 09:40
Copy link
Contributor

@miggol miggol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

@EdoStorm96 EdoStorm96 merged commit 6cf6a38 into major/4 Dec 16, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants