Clearer faculty warning messages #676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miggol
approved these changes
Jun 17, 2024
There was a problem hiding this comment.
I approve. It's a lot clearer like this, and the different messages make it easier for us to tell what's going on based on user feedback.
The only change I might suggest is to not say "employed" but "associated with" to be more inclusive to students. With something like "aangesloten bent bij" in Dutch. But that's just a suggestion.
EdoStorm96
approved these changes
Jun 18, 2024
miggol
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the faculty-warning texts to be more honest and nuanced. While the hotfix I deployed today should make this less important, I still think this changer is needed.
The faculty-known message variant is, mostly, the same. It adds a line stating that the portal is usable despite the warning.
The faculty-unknown message is now honest that we don't have that info, and also assures the portal is still usable.
New faculty known message:
New faculty unkown message:
(Ignore the colors, I have darkreader on)