fix: ensure faculty is saved on user create #664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miggol
approved these changes
Apr 26, 2024
EdoStorm96
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re #611
Note: once again this PR targets acceptation, as I deem this fix important enough to deploy quickly. It can be cleanly applied to develop too tho, if that's what ya'll prefer
I've tested if the problem is related to the first login, and while I was skeptical it really was this problem, it does seem to be. So, this PR adds one line of code to ensure the user model is saved first. As this 'field' is the last to be 'set', it should be save to do. (And even if that's not the case, our try/catch will prevent any real problems for the user).
I'm still a bit mystified why the percentage of users without a faculty set is this high if it's only a problem for initial logins... But this fix should at least aleviate the problem a bit.