fix: remove explicit protocol prefix from file links #637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also adding quotations around the URL
miggol
added a commit
that referenced
this pull request
Mar 27, 2024
* Hotfix/to conclude review api view qs bug (#629) * fix: add is_committee_review check to ToConcludeReviewApiView qs * fix: add is_committee_review check to other API views * formatting --------- Co-authored-by: Ty Mees <[email protected]> * fix: apply is_committee_review to filter in get_committee_decisions() * formatting * fix: Save reviews after closure in update_go * fix: hacky changes to working of end_date in qs * formatting * fix: remove explicit protocol prefix from file links (#637) * fix: remove explicit protocol prefix from file links Also adding quotations around the URL * feat: Add protocol prefix to BASE_URL for consistency --------- Co-authored-by: Edo Storm <[email protected]> Co-authored-by: Ty Mees <[email protected]> Co-authored-by: Edo Storm <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #636
Also adds quotations around the URL.
The development
BASE_URLin settings.py now also contains ahttps://for consistency with server deployments.