Hotfix/to conclude review api view qs bug #629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploy workload fix to prod
Merge hotfix to master
Merge acc into master for deployment
7 tasks
tymees
requested changes
Mar 21, 2024
There was a problem hiding this comment.
Changes look good. One small comment, but that is not an actual issue AFAIK.
However, the Request Changes is related to the branch. Please go through the acceptation branch first. You do not have to do an acceptation deploy (alhtough, you may if you want), this is purely a git-thing.
(We've had... Issues with backmerging master into acc and then into dev).
There was a problem hiding this comment.
While not an issue, OpenSupervisorDecisionApiView's QS is still written with the old behaviour in mind. In this specific case, it works out. Still, probably a refactor candidate at some point.
Again, no fix is needed for this hotfix
miggol
added a commit
that referenced
this pull request
Mar 21, 2024
* fix: add is_committee_review check to ToConcludeReviewApiView qs * fix: add is_committee_review check to other API views * formatting --------- Co-authored-by: Edo Storm <[email protected]> Co-authored-by: Ty Mees <[email protected]>
miggol
added a commit
that referenced
this pull request
Mar 27, 2024
* Hotfix/to conclude review api view qs bug (#629) * fix: add is_committee_review check to ToConcludeReviewApiView qs * fix: add is_committee_review check to other API views * formatting --------- Co-authored-by: Ty Mees <[email protected]> * fix: apply is_committee_review to filter in get_committee_decisions() * formatting * fix: Save reviews after closure in update_go * fix: hacky changes to working of end_date in qs * formatting * fix: remove explicit protocol prefix from file links (#637) * fix: remove explicit protocol prefix from file links Also adding quotations around the URL * feat: Add protocol prefix to BASE_URL for consistency --------- Co-authored-by: Edo Storm <[email protected]> Co-authored-by: Ty Mees <[email protected]> Co-authored-by: Edo Storm <[email protected]>
miggol
added a commit
that referenced
this pull request
Apr 3, 2024
* fix: correct 'start of proposal' redirect for pre_approved * fix: improve buttons on proposal_confirmation.html * fix: diff bugfix * fix: buttons on task and session delete * fix: formatting * Revert 'confirmation sent' text on button back to past tense * Hotfix/to conclude review api view qs bug (#629) * fix: add is_committee_review check to ToConcludeReviewApiView qs * fix: add is_committee_review check to other API views * formatting --------- Co-authored-by: Ty Mees <[email protected]> * feat: is_final_decision method on Decision model * feat: Warning when submitting a final decision * fix: A capital letter * fix: Show decide review action when already decided * feat: translations * fix: Some fuzzy or missing translations * feat: Turn final deicision warning into alert box * fix: Same translation somehow needed fixing again... * feat: Alternate action description for feedback editing --------- Co-authored-by: Edo Storm <[email protected]> Co-authored-by: Edo Storm <[email protected]> Co-authored-by: Ty Mees <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #628. The is_committee_review check was not properly implemented yet, which led to some stray supervisor reviews, appearing in certain API views. See the issue for more info. This should fix the problems.