Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HOTFIX: allow secretary-induced changes to update the canonical PDF #618

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

tymees
Copy link
Member

@tymees tymees commented Mar 4, 2024

This PR targets acceptation, in order to quickly deploy this fix

This is a band-aid fix for #617, which only ensures the PDF is regenerated if the secretary updates one of the uploaded documents.

There is still the question why there were problems with this, but having taken a quick look at the code I think I know. I'll update that issue with my theory. (Which will still warrant this change btw).

@tymees tymees requested review from miggol and EdoStorm96 March 4, 2024 12:50
Copy link
Contributor

@EdoStorm96 EdoStorm96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, looks good :)

Copy link
Contributor

@miggol miggol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good!

@tymees tymees merged commit 008206b into acceptation Mar 4, 2024
2 checks passed
@tymees tymees deleted the fix/canonical-pdf-regenerate branch March 4, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants