fix: fix broken tests due to invalid fixture names #615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turns out our PDF generator has a pretty strange CSS parser that does not allow `font-weight: 400` (as 400 is the default).
EdoStorm96
reviewed
Feb 29, 2024
|
That would also involve debugging the load-order again (as it's dependent on filenames for the load command, not tests). That's a bit more work than just some simple renames. Would you be fine with a separate issue for that? |
|
Ahh, ok. Yeah, it's not such a big deal. I'd be fine with that :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My bad; should've caught this when I made this change.
Edit:
I also cleaned up the test-runner output with the other two commits:
The first removes the 'font-weight' spam. Turns out our PDF generator has a pretty strange CSS parser that does not allow
font-weight: 400(as 400 is the default) in the font definition. Any other CSS parser thinks this is fine, if redundant, but well...The 'Not saving PDF' warning spam is disabled by disabling all log levels below WARNING (inclusive) for the proposal-submit tests only.