Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email changes #614

Merged
merged 5 commits into from
May 16, 2024
Merged

Email changes #614

merged 5 commits into from
May 16, 2024

Conversation

tymees
Copy link
Member

@tymees tymees commented Feb 28, 2024

This PR addresses #529. It was a pain, but I think I got everything right.

As a bonus, I also implemented #623, as it was kinda related.

I cannot wait till we have the new mailing code. Keeping multiple versions in sync is a pain

@tymees tymees marked this pull request as draft February 28, 2024 17:06
@tymees tymees marked this pull request as ready for review April 4, 2024 16:55
@tymees tymees changed the title text: initial mail-rewording pass Email changes Apr 4, 2024
Comment on lines +293 to +294
"proposal_url": settings.BASE_URL
+ reverse("reviews:decide", args=(decision.pk,)),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this var isn't used in the template, as Desiree's text didn't contain it. It's here because it was in the other reminder mail code I copied, so I left it in for the inevitable 'why isn't there a link' comments.

Feel free to nudge me to add it to the e-mail, but I'm tired atm :P

@tymees tymees requested review from EdoStorm96 and miggol April 4, 2024 17:00
Copy link
Contributor

@EdoStorm96 EdoStorm96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could not find any faults. Respect for doing this haha. 😅 I suppose it would indeed be best to add a link to reminder_supervisor already, if you can find the energy.

How do cron jobs work though? Where do these reside for ethics?

@tymees tymees merged commit c4685cc into develop May 16, 2024
4 checks passed
@tymees tymees deleted the feature/mail_updates branch May 16, 2024 13:13
@tymees
Copy link
Member Author

tymees commented May 16, 2024

How do cron jobs work though? Where do these reside for ethics?

Cron jobs are set on the server OS; Under the hood, it's a program that runs in the background, that just fires off 'shell commands' depending on the configured interval. We configure it to run a django management command ('send-reminders').

As described in #315, we run this:
0 7 * * * /<snip>/data/env/bin/python /<snip>/data/source/manage.py send_reminders >/dev/null 2>&1

This means 'on minute 0, hour 7, any day, any month and any year, execute the following command'.

(So, 15 7 1 3 2025 would be 'run this command on the first of march, 2025 at 7:15'. Nobody would do this, as this would only run once ever)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants