-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Email changes #614
Email changes #614
Conversation
reviews/templates/mail/submitted_longroute_other_applicants.html
Outdated
Show resolved
Hide resolved
reviews/templates/mail/submitted_longroute_other_applicants.txt
Outdated
Show resolved
Hide resolved
"proposal_url": settings.BASE_URL | ||
+ reverse("reviews:decide", args=(decision.pk,)), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this var isn't used in the template, as Desiree's text didn't contain it. It's here because it was in the other reminder mail code I copied, so I left it in for the inevitable 'why isn't there a link' comments.
Feel free to nudge me to add it to the e-mail, but I'm tired atm :P
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could not find any faults. Respect for doing this haha. 😅 I suppose it would indeed be best to add a link to reminder_supervisor
already, if you can find the energy.
How do cron jobs work though? Where do these reside for ethics?
Cron jobs are set on the server OS; Under the hood, it's a program that runs in the background, that just fires off 'shell commands' depending on the configured interval. We configure it to run a django management command ('send-reminders'). As described in #315, we run this: This means 'on minute 0, hour 7, any day, any month and any year, execute the following command'. (So, |
This PR addresses #529. It was a pain, but I think I got everything right.
As a bonus, I also implemented #623, as it was kinda related.
I cannot wait till we have the new mailing code. Keeping multiple versions in sync is a pain