Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect supervisor to the right update page #613

Merged
merged 1 commit into from
Feb 26, 2024
Merged

Conversation

tymees
Copy link
Member

@tymees tymees commented Feb 20, 2024

During initial triage of the issue, I saw that actually fixing the issue was easier than to write it. So here we go.

This PR makes sure supervisors get the right update link on their 'decide page'. Previously, it would always redirect to the general one.

(I also moved the link-logic to python to keep the template sane).

@tymees tymees requested review from miggol and EdoStorm96 February 20, 2024 16:04
Copy link
Contributor

@EdoStorm96 EdoStorm96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I approve, given the current state of the code. I am wondering though if it wouldn't be nicer to have a separate view for supervisor decisions and reviewer decisions. I was initially a bit confused looking at this template again. I suppose this would be a bit of work to do and its also beyond the scope of this issue.

@tymees
Copy link
Member Author

tymees commented Feb 26, 2024

It's the same view, as the underlying code is almost identical. So, taking care of the differences with some if-statements is more maintainable than having to remember to edit 2 views.

The same used to hold true for the template as well, but over the years we've been adding more and more differences. So yeah I agree, at this point, just loading a different template would make more sense.

Sounds like a great issue for when we're going to have to rewrite our templates anyway (updating to DSC 3)

@tymees tymees merged commit b1e707f into develop Feb 26, 2024
3 of 4 checks passed
@tymees tymees deleted the fix/supervisor-edit branch February 26, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants