Give privileged groups archive access regardless of Humanities affiliation #609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tymees
requested changes
Feb 14, 2024
main/utils.py
Outdated
Comment on lines
148
to
151
| "AK", | ||
| "LK", | ||
| "Secretaris", | ||
| "Primaire secretaris", |
There was a problem hiding this comment.
Please use the values in constants.py
EdoStorm96
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it's kind of weird that a secretary or chamber member can't view the archive if they're not in the humanities faculty. This PR resolves this by allowing privileged groups in.
Notes:
FacultyRequiredMixinto useUserPassesTestMixinto be able to chain it with the new mixin. But once I had written the utility function for the menus, I realized this was ultimately unnecessary. Because I do believeUserPassesTestMixinoffers more flexibility, I left this change in. But I'm happy to revert it, there's an argument to be made for both methods.