Fix/minor fixes #605
Merged
Fix/minor fixes #605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Feb 1, 2024
tymees
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #592, #596 and #597. The first two are just minor textual changes, so not much to see there.
#596 was a bit more work. There did not appear to be a datepicker widget, which was a significant improvement over what we had, so, despite trying some other things, we ended up sticking with the one we had ... Desiree said that she would be using it less, if the initial period would be set to 3 months.
Because of the requests she mad about access to this page, I ended up adding another group (
GROUP_PO = "Privacy officer") ... It is a bit annoying that this is only really used for regulating access to this specific page, but maybe we will have some other use for it in the future. I wanted to streamline fetc_filter.py to accomodate for the many possible combinations of groups ... I made a 'base' functionis_in_groups(current_user, groups)which can be used to create filters for specific groups.Otherwise, this is pretty straightforward.