Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: made sure fixtures are loaded in the correct order #604

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

tymees
Copy link
Member

@tymees tymees commented Feb 1, 2024

For complicated reasons I had to create yet another clone of the project (counter is on 4 now lol). I thought, let's use the new fancy load-fixtures command!

Only to discover that it had some issues with load-order. It tried to load registrationkinds before registrations, but registrationkinds depends on registrations. So, this PR addresses that issue:

  1. It sorts the list of discovered fixtures, as os.listdir returns the list in an arbitrary ordering
  2. Adds a number to the filenames in tasks, to ensure one is loaded before the other

The other fixtures loaded fine without the extra filename ordering, so I left them as-is

@tymees tymees requested review from miggol and EdoStorm96 February 1, 2024 14:16
Copy link
Contributor

@EdoStorm96 EdoStorm96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me!

@tymees tymees merged commit ebd6342 into develop Feb 7, 2024
2 of 4 checks passed
@tymees tymees deleted the fix/fixture-load-order branch February 7, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants