The big reformat #600
The big reformat #600
Conversation
Also, add trimmed to all blocktrans blocks
tymees
requested review from
EdoStorm96 and
miggol
and removed request for
EdoStorm96
This is totally not a formatting problem I used to check the checker, which I accidentally left in while committing. Well.... At least we know the CI check works :')
|
Hmmm, the djlint check seems to be checking.... reads log... DSC 2? Wut... I'll look at that next week, I'm done EDIT: Github downloaded DSC into a local folder, so that folder had to be excluded. Everything is green now! :) |
Okay, didn't realize there is this one case where we use Django-in-CSS. Luckily it's just the one. Right?
Haha, lol |
There was a problem hiding this comment.
Only wonky translation I found was the following:
#: reviews/templates/reviews/review_detail_sidebar.html:46
#, python-format
msgid "Reviewronde gestart op <br /> %(date_start)s."
msgstr "eviewing round started on %(date_start)s."Went looking for other msgstrs that don't start with a capital letter, and it turns out there's only like 10 of those total. They're all good.
I took the liberty of committing translations fixes directly into this branch. But my other comment still needs looking at.
| en | ||
| volgende | ||
| stap> | ||
| >") }}" /> |
There was a problem hiding this comment.
Interesting... Looks like DJLint has a bug when it comes to the _('[..]') syntax.
Should be fixed now, I moved the translated string to a variable and referenced that in the default filter
|
Fun fact, FF crashes if you try to search through the diff of the locale file lol
I'm not seeing any commits? |
This PR reformats the entire codebase using Black and DJLint for python and templates respectively.
I checked every file after reformat; the black reformat went well, no issues.
The DJLint reformat had a couple problems:
<ul><p><li>[..]</li></p></ul>. Thosep's aren't allowed there<\br>- yeah dunno how this happenedblocktranswithouttrimmedmessed things up BAD. (It effectively disabled formatting, even for a couple of lines after the end tag). So, I addedtrimmedto every blocktrans.Lastly, this PR enabled CI based checks to see if someone forgot to format their code :)