feature: user-friendly page for closed supervisors reviews #595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tymees
commented
Jan 10, 2024
| {% endblocktrans %} | ||
| </p> | ||
| </div> | ||
| {% include "reviews/review_detail_sidebar.html" %} |
There was a problem hiding this comment.
I decided to add the review sidebar to the right of the main content instead of the left as we do in other places.
The main content is way more important for this page, and I felt that having the sidebar on the left distracted from the main content.
EdoStorm96
approved these changes
Jan 11, 2024
locale/en/LC_MESSAGES/django.po
Outdated
| msgid "" | ||
| "Je hebt deze aanvraag al beoordeeld. Controleer of dit inderdaad de aanvraag " | ||
| "is die je wou beoordelen. Op <a href=\"%(my_supervised_url)s\">deze pagina</" | ||
| "a> vind je alle aanvragen waarvan je eindverantwoordelijke bent." |
There was a problem hiding this comment.
Ik zou zeggen:
"is die je wilde beoordelen. Op <a href=\"%(my_supervised_url)s\">deze pagina</"
"a> vind je alle aanvragen waarvan je de eindverantwoordelijke bent."
| "toevoegen/aanpassen" | ||
| msgstr "" | ||
| "This application has already been assessed, so you cannot add/adjust your " | ||
| "assessment" |
There was a problem hiding this comment.
Looking back at it, I'd say `add/change'?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #594
This PR adds a page supervisors are redirected to if they access a decision URL for a proposal they've already reviewed. The issue talks about a similar page for committee reviews, but looking at the code I decided to just redirect them to the review detail page instead. In that case, they do get a message using the messages framework informing them the review has been concluded.
As part of this change, I also refactored
UserAllowedMixininto a decision-only mixin (it was only used for decisions nowadays). I also moved the access check to the dispatch method instead; that way, we can still retrieve the object. This was needed, as I needed the actual object to properly redirect users and the previous approach blocked object retrieval.Another small refactor: previously, the success URL was decided by looking at the user making the decision; I decided to look at the review type instead as that felt more consistent in behavior
As always, please double check the texts I added. Even more so for the translations,
as I was very lazy