Feature/new group chairs etc #591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Dec 19, 2023
tymees
approved these changes
Jan 8, 2024
main/templatetags/fetc_filters.py
Outdated
Comment on lines
35
to
37
| """ | ||
| Check whether the current user is in the 'Chair' group | ||
| """ |
There was a problem hiding this comment.
This docstring contradicts both the function name and the actual logic.
If the other functions didn't have a docstring I would suggest removing it altogether, as I feel like the docstring is unneeded.
|
Actually, the workload is not meant for privacy officers and/or data manager, but I'm afraid this can't be solved, can it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two issues: a bigger one and a minor one. To start with the bigger one:
#539: So, I have added a new group, which is meant for chairs, the privacy officer and the data manager (
GROUP_CHAIRin constants.py). This group can basically see everything that the secretary can see, as long as they are a also a member of the chamber in question. (see menus.py. for an idea ...) However, they cannot perform any actions. They can just look at all the lists and open up a detail view for a proposal. However, no review actions are available to this group. This is what we discussed with Desiree. For now, I've even granted this group access to the committee workload overview, as I thought it might be useful. What do you think about this? Otherwise, this seems to work well :)#583: In the last meeting, we decided to just clarify this with a simple textual change instead of a new option. Most revisions end up taking about two weeks anyways, so for now, we just treat it as a short route review, behind the scenes. Desiree was satisfied with this solution