Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some links to attachments are not clickable #830

Closed
tijmenbaarda opened this issue Dec 24, 2024 · 2 comments
Closed

Some links to attachments are not clickable #830

tijmenbaarda opened this issue Dec 24, 2024 · 2 comments
Assignees

Comments

@tijmenbaarda
Copy link

tijmenbaarda commented Dec 24, 2024

On the review page, these attachment links that are marked as "new" are not clickable (browser: Chrome):

afbeelding

When opening the links manually (by copying and pasting the URL), a server error occurs.

URL: https://fetc.tst.hum.uu.nl/reviews/show/11/

@miggol
Copy link
Contributor

miggol commented Jan 8, 2025

This was a combination of non-existing files and the download="filename.pdf" attribute on the link, which results in a click doing nothing.

Non-existing files should be fixed with #832 and a hotfix was put in major/4 for the latter part of the problem.

@miggol miggol closed this as completed Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants