fix: Actually implement stepper.filled_slots

DH-IT-Portal-Development · Jan 8, 2025 · a11756d · a11756d
1 parent da86b91
commit a11756d
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 4 deletions.
diff --git a/proposals/utils/pdf_diff_sections.py b/proposals/utils/pdf_diff_sections.py
@@ -742,7 +742,7 @@ def _all_slots_list(self, proposal):
         from proposals.utils.stepper import Stepper
 
         stepper = Stepper(proposal)
-        slots = [slot for slot in stepper.attachment_slots if slot.attachment]
+        slots = stepper.filled_slots
 
         return slots
 

diff --git a/reviews/utils/attachment_utils.py b/reviews/utils/attachment_utils.py
@@ -186,9 +186,8 @@ def get_containers(
         from proposals.utils.stepper import Stepper
 
         stepper = Stepper(self.proposal)
-        filled_slots = [slot for slot in stepper.attachment_slots if slot.attachment]
         containers = DocList(
-            filled_slots,
+            stepper.filled_slots,
             proposal=self.proposal,
         ).as_containers()
         return containers

diff --git a/reviews/views.py b/reviews/views.py
@@ -658,7 +658,7 @@ def get_slots(
     ):
         proposal = self.get_review().proposal
         stepper = Stepper(proposal)
-        return [slot for slot in stepper.attachment_slots if slot.attachment]
+        return stepper.filled_slots
 
     def per_object(
         self,