Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geo cord polygon query #320

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

Geo cord polygon query #320

wants to merge 17 commits into from

Conversation

104H
Copy link
Contributor

@104H 104H commented Jul 28, 2023

Allows the user to define the query polygon in any arbitrary coordinate system along with a WKT string of the coordinate system.

The polygon is then transposed from the query-defined system to the system followed by the project.

@jarkenau
Copy link
Member

@Mark-Niemeyer what should we do with this? Close PR for now and create an issue?

@mmeijerdfki mmeijerdfki force-pushed the geoCordPolygonQuery branch 2 times, most recently from 293e96c to 85d1592 Compare August 24, 2024 15:23
@mmeijerdfki
Copy link
Contributor

As a follow up:
This PR enables querying in the various spatial reference systems supported by PROJ.

First the polygon from the query is transformed into the projects geodetic spatial coordinate system, if needed.
After that the polygon is transformed into the projects map frame to calculate the spatial relevancy of the stored objects.

Changelog:

  • build and install a newer version of PROJ from source
  • new property for the flatbuffers query crsString with valid values of codes from https://spatialreference.org/, "map" or "project"
    • if crsString == "map" no transforms will be done and it is assumed that the query is done spatially in the map frame and the query will be executed in the map frame
    • if crsString == "project" only the transform to topocentric will be done, the query will be done in the projects spatial reference system, the query will be executed in the projects spatial reference system
    • if crsString == "<other spatial reference code>" the polygon will be transformed to the projects spatial reference system first and then projected to topocentric
  • removed the inMapFrame flag from the query as this is now baked into crsString
  • added 3 new tests to check the transformations behavior
  • added and updated docs to reflect these additions and changes

Note:
The docker containers have to be rebuild on this branch to pass the tests.

@mmeijerdfki mmeijerdfki marked this pull request as ready for review October 8, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants