Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split SEGMENTSIZE_XY and add an autosize config #132

Open
wants to merge 25 commits into
base: master
Choose a base branch
from
Open

Split SEGMENTSIZE_XY and add an autosize config #132

wants to merge 25 commits into from

Conversation

realSquidCoder
Copy link
Contributor

@realSquidCoder realSquidCoder commented Jan 13, 2025 •
edited
Loading

Fixes: #18

@realSquidCoder realSquidCoder marked this pull request as ready for review January 13, 2025 17:44
@silverwing235
Copy link

...Weird typo in the title, though. Somewhere between 'config' and 'conifer'. WPM issue?

@realSquidCoder realSquidCoder changed the title Split SEGMENTSIZE_XY and add an autosize conifg Split SEGMENTSIZE_XY and add an autosize config Jan 13, 2025
@realSquidCoder
Copy link
Contributor Author

...Weird typo in the title, though. Somewhere between 'config' and 'conifer'. WPM issue?

*config, fixed now

myk002
myk002 reviewed Jan 14, 2025
View reviewed changes
Config.cpp Show resolved Hide resolved
configs/init.txt Outdated Show resolved Hide resolved
configs/init.txt Outdated Show resolved Hide resolved
Config.cpp Outdated Show resolved Hide resolved
@myk002 myk002 mentioned this pull request Jan 15, 2025
Merged
myk002
myk002 reviewed Jan 15, 2025
View reviewed changes
Copy link
Member

@myk002 myk002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs changelog for new feature

common.h Outdated Show resolved Hide resolved
commonTypes.h Outdated Show resolved Hide resolved
main.cpp Outdated Show resolved Hide resolved
main.cpp Outdated Show resolved Hide resolved
Config.cpp Outdated Show resolved Hide resolved
myk002
myk002 reviewed Jan 16, 2025
View reviewed changes
Config.cpp Outdated Show resolved Hide resolved
Config.cpp Outdated Show resolved Hide resolved
main.cpp Outdated Show resolved Hide resolved
resources/keybinds.txt Outdated Show resolved Hide resolved
myk002
myk002 reviewed Jan 16, 2025
View reviewed changes
Config.cpp Outdated Show resolved Hide resolved
Contributions.txt Outdated Show resolved Hide resolved
common.h Outdated Show resolved Hide resolved
docs/changelog.txt Outdated Show resolved Hide resolved
main.cpp Outdated Show resolved Hide resolved
myk002
myk002 previously approved these changes Jan 17, 2025
View reviewed changes
common.h Outdated Show resolved Hide resolved
@myk002
Copy link
Member

myk002 commented Jan 17, 2025

there is an encoding error with the changed-but-not-changed-but-actually-changed contributors.txt file. I'll see if I can fix it up locally before merge

@myk002 myk002 dismissed their stale review January 17, 2025 02:31

AUTO doesn't work

@myk002
Copy link
Member

myk002 commented Jan 17, 2025

it looks like ssConfig.autosize_segmentX and ssConfig.autosize_segmentY are never getting set.

myk002
myk002 reviewed Jan 17, 2025
View reviewed changes
Config.cpp Outdated Show resolved Hide resolved
Config.cpp Show resolved Hide resolved
@myk002 myk002 mentioned this pull request Jan 19, 2025
Closed
@realSquidCoder realSquidCoder mentioned this pull request Jan 19, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ab9rf ab9rf ab9rf left review comments

@myk002 myk002 myk002 left review comments

Assignees
No one assigned
Labels
None yet
Projects
51.01-r1
Status: Being worked on
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

An option for segment_size_XY:auto (also maximum to render)
4 participants
@realSquidCoder @silverwing235 @myk002 @ab9rf