gui/cult lists #874
Closed
gui/cult lists #874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lethosor
reviewed
Oct 24, 2023
| -- error handling | ||
|
|
||
| if not dfhack.isMapLoaded() then | ||
| qerror('This script requires fort mode to be loaded') --(qerror might be typo, and should probably be error) |
There was a problem hiding this comment.
Comment on lines
+8
to
+12
| ------------------------------------------------------------------------------------------ | ||
| -- Noticed that this was an open fork, but hadn't been touched in months, so decided to have a shot at getting it finished | ||
| -- I am not super familiar with lua or C/C++ but will see how thinbgs go. | ||
| -- Doesn't seem like there are many problems with the script itself just needed to be formatted | ||
| ----------------------------------------------------------------------------------------- |
There was a problem hiding this comment.
This bit should be removed - more suitable for the PR description
| @@ -0,0 +1,58 @@ | |||
| gui/cult-lists.lua | |||
There was a problem hiding this comment.
There were several comments left on the original PR (https://github.com/DFHack/scripts/pull/664/files), and it looks like many could be addressed here as well. This line in particular needs the .lua suffix removed, for one thing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #664. Has been months since last activity.
Checked outstanding issues, only seemed to be formatting, and one typo in docs/gui/cult-lists, haven't had time to test in-game yet