Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/all-unmet-needs (only list) #1192

Closed
wants to merge 32 commits into from
Closed

Conversation

rslgp
Copy link

@rslgp rslgp commented Jun 18, 2024

No description provided.

Copy link
Member

@myk002 myk002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The allneeds script already sorts by focus impact. Moreover, I'm not keen on adding coded nicknames like this. I'd rather either implement bulk nicknaming as part of the in-progress gui/manipulator or extend autolabor to set labors automatically so units attend to their specific needs

@myk002
Copy link
Member

myk002 commented Jun 19, 2024

How about if you instead turn this into a notification that appears on the notification panel? It can list at most the top two or three needs of the fort (as long as they are above some threshold). Maybe also report on how focused the fort is overall.

E.g.

Fort is 92% focused
Fort is 79% focused; top need: Pray or meditate
Fort is 45% focused; top needs: Relax, Martial training

Clicking on the message would zoom to the dwarves who have especially high needs

@rslgp rslgp closed this Jun 19, 2024
@rslgp rslgp reopened this Jun 19, 2024
@rslgp
Copy link
Author

rslgp commented Jun 19, 2024

i removed the renaming part from code, that script is a different approach from allneeds, focused only on unmet filtering out the others needs

@myk002
Copy link
Member

myk002 commented Jun 19, 2024

If it's just a filter, then can this be implemented as an option for allneeds? It doesn't seem worth adding an entirely new tool for a minor variation in behavior.

@myk002
Copy link
Member

myk002 commented Jul 2, 2024

closing this PR for now; please reopen when you'd like to take it further. I think the next steps are to integrate the functionality into allneeds as an option.

@myk002 myk002 closed this Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants