Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mitigations for deadlock behavior on Linux #5186

Merged
merged 3 commits into from
Jan 10, 2025
Merged

Mitigations for deadlock behavior on Linux #5186

merged 3 commits into from
Jan 10, 2025

Conversation

myk002
Copy link
Member

@myk002 myk002 commented Jan 10, 2025 •
edited
Loading

  • Fix unintended assert when interrupting Lua
  • Protect the remote server from try_autocomplete deadlock when attempting to run kill-lua but misspelling it
  • disable ConditionalCoreSuspender on Linux (until we can figure out why it's misbehaving)

Discord discussion: https://discord.com/channels/793331351645323264/807444515194798090/1327095546804047995

myk002 added 2 commits January 9, 2025 20:46
@myk002
turn off try_autocomplete for remote connections
e464afc 
and add explanatory comment
@myk002
disable ConditionalCoreSuspender on Linux
20cd792 
until we can figure out why it doesn't behave properly
@myk002 myk002 merged commit e9be4ce into DFHack:develop Jan 10, 2025
14 checks passed
@myk002 myk002 deleted the myk_locking branch January 10, 2025 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ab9rf ab9rf ab9rf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
50.15-r2
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@myk002 @ab9rf