split plugin lua macros to separate header

[ab9rf]

this will reduce the number of translation units that require the includes from the lua dependency

[myk002]

Don't forget to get rid of those lines I just added in Plugins.cmake:

        # since PluginManager currently uses Lua headers, even when Lua is not used
        get_target_property(lua_INCLUDES lua INTERFACE_INCLUDE_DIRECTORIES)
        target_include_directories(${PLUGIN_NAME} PRIVATE ${lua_INCLUDES})

[myk002]

Maybe also add a comment to plugins/examples/skeleton.cpp about which header files to include if the plugin makes use of Lua

[ab9rf]

Don't forget to get rid of those lines I just added in Plugins.cmake:

        # since PluginManager currently uses Lua headers, even when Lua is not used
        get_target_property(lua_INCLUDES lua INTERFACE_INCLUDE_DIRECTORIES)
        target_include_directories(${PLUGIN_NAME} PRIVATE ${lua_INCLUDES})

my base branch for this PR is before that was merged, so i either have to rebase, or cherry-pick that commit so i can reverse it. it'll be a bit

[myk002]

you can also merge develop into this branch

[ab9rf]

you can also merge develop into this branch

i tried that but it made a mess of the PR

[ab9rf]

need to add lua include to add-spatter because it uses interposes, which have a dependency on DataFuncs that probably isn't absolutely necessary but will need more work to unwind

eventExample also had problems, but there we can just remove the unnecessary headers, which included VTableInterpose.h, Export.h, and Console.h. removed

i can't figure out how to get add-spatter to compile with backing out the change in Plugins.cmake, so i'm backing that out for now, we can catch that subsequently

[myk002]

i can't figure out how to get add-spatter to compile with backing out the change in Plugins.cmake, so i'm backing that out for now, we can catch that subsequently

If it's just add-spatter, we can include Lua headers for just that build target in cmake by adding this to plugins/CMakeLists.txt:

    if(BUILD_PLUGINS)
        # remove when VTableInterpose.h no longer has a dependency on DataFuncs.h
        get_target_property(lua_INCLUDES lua INTERFACE_INCLUDE_DIRECTORIES)
        target_include_directories(add-spatter PRIVATE ${lua_INCLUDES})
    endif()

can be added just after dfhack_plugin(add-spatter add-spatter.cpp)