-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
generate pdb files for windows builds #5114
Conversation
where are these going to live? |
The idea I had going into this was to package them as an artifact that could be downloaded from GitHub. I was testing to be sure the build worked before I made changes to the workflow files. However, if we have to choose between ccache and pdb files for Windows builds, there needs to be a more serious discussion about cost/benefit of this change. |
so we can retrieve them when debugging player-reported crashes
in particular, don't double-find pdbs that have already been copied into the pdb directory
So the resulting workflow would be:
|
Merging so we can test PDB generation for Steam deployments. We can address further comments in follow-up PRs |
so we can retrieve them when debugging player-reported crashes on Windows
Fixes: #4991
This PR also adds a link to the online debug symbols to stderr.log and a new
dfhack-status.dat
file in the savegame directory.example contents of the status file:
We normally ask the player for their stderr.log when debugging crashes, so the link will be available even if the player does not have a savegame to share.
Example contents of
stderr.log
:The link takes you to the GitHub workflow run results, where you can download the PDBs: