Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add graphics support for building-hacks #4380
base: develop
Are you sure you want to change the base?
Add graphics support for building-hacks #4380
Changes from all commits
9a7370f
c4266c5
6ade67e
b295d57
c67d685
fe0bc2f
2cdeee8
010928c
3138d3a
cd59595
16bc0b6
bd09cb5
60e21b9
796f480
11ef74a
61920e3
73f2d23
3cd0bc8
6ce0bcc
6a48246
2a1db17
1e68060
6faacc0
aaf3f9c
a975fd9
e462846
1439fcb
9e14ac4
e8763fe
41a0df5
5360b98
b27a61a
d43fb3a
3355f6b
f49d203
92fa5cf
7a79fab
f2c038d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when would you want this set to false?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why does onUpdateAction exist as a Lua event, then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The plugin lua part still uses that event (i.e.
setOnUpdate
function)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not convinced this is sufficient reasoning. Why do you need a lua event to communicate with your own Lua layer? Why can't you call the Lua functions directly?