Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update renderer to match bay12 #823

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ab9rf
Copy link
Member

@ab9rf ab9rf commented Jan 26, 2025

looks like this was added in or before v50.10 but we never updated to match

Fixes: #822

looks like this was added in or before v50.10 but we never updated to match
Copy link
Member

@myk002 myk002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@quietust can you merge this at your convenience so it doesn't interfere with your restructuring work?

@quietust quietust self-requested a review January 29, 2025 22:28
@@ -634,15 +634,19 @@
<vmethod name='update_full_viewport'> <pointer type-name='graphic_viewportst' name='vp'/> </vmethod>
<vmethod name='update_full_map_port'> <pointer type-name='graphic_map_portst' name='vp'/> </vmethod>
<vmethod name='clean_tile_cache'/>
<vmethod name='tidy_tile_cache'/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like there should also be void clean_cached_tile(int32_t texpos, float r, float g, float b, float br, float bg, float bb, uint32_t flag) here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Being worked on
Development

Successfully merging this pull request may close these issues.

virtual definitions of renderer and subclasses are not correct
3 participants