Merge pull request #98 from DEFRA/BAU-make-sonarcloud-run-before-publish

BAU: run sonarcloud before publish
DEFRA · Jan 2, 2025 · aae905a · aae905a
2 parents 9166f75 + dd872b9
commit aae905a
Showing 1 changed file with 7 additions and 6 deletions.
diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml
@@ -32,6 +32,12 @@ jobs:
           npm run build
           npm test
 
+      - name: SonarCloud Scan
+        uses: SonarSource/sonarcloud-github-action@master
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+          SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
+
       - name: Start docker compose
         run: |
             docker compose up --wait-timeout 300 -d --quiet-pull
@@ -42,7 +48,7 @@ jobs:
         env:
           BROWSERSTACK_USER: ${{ secrets.BROWSERSTACK_USER }}
           BROWSERSTACK_KEY: ${{ secrets.BROWSERSTACK_KEY }}
-  
+
       - name: cleanup
         if: always()
         run: docker compose down
@@ -52,8 +58,3 @@ jobs:
         with:
           github-token: ${{ secrets.GITHUB_TOKEN }}
 
-      - name: SonarCloud Scan
-        uses: SonarSource/sonarcloud-github-action@master
-        env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-          SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}