Merge pull request #175 from DEFRA/Fix-user-journey-tests

Fix for user journey tests
DEFRA · Jan 30, 2025 · 01922a8 · 01922a8
2 parents 0d80197 + 6fb590e
commit 01922a8
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 8 deletions.
diff --git a/user-journey-tests/helpers/testHelpers/destination.js b/user-journey-tests/helpers/testHelpers/destination.js
@@ -4,6 +4,7 @@ import taskListPage from '../../page-objects/taskListPage.js'
 import { selectElement } from '../page.js'
 import destinationSelectionPage from '../../page-objects/destination/destinationSelectionPage.js'
 import generalLicencePage from '../../page-objects/destination/generalLicencePage.js'
+import destinationAnswersPage from '../../page-objects/destination/destinationAnswersPage.js'
 
 // Helper function to complete the origin task
 const completeDestinationTask = async (radioType) => {
@@ -27,6 +28,7 @@ const completeDestinationTask = async (radioType) => {
     default:
       throw new Error(`Unsupported radio type: ${radioType}`)
   }
+  await destinationAnswersPage.verifyPageHeadingAndTitle()
 }
 
 export default completeDestinationTask
diff --git a/user-journey-tests/helpers/testHelpers/receivingLicence.js b/user-journey-tests/helpers/testHelpers/receivingLicence.js
@@ -24,6 +24,7 @@ const completeLicenceTask = async ({
   await ownerNamePage.inputNameAndContinue(firstName, lastName)
   await receiveMethodPage.selectEmailAndContinue()
   await emailPage.inputEmailAndContinue(email)
+  await licenceAnswersPage.verifyPageHeadingAndTitle()
   await validateElementVisibleAndText(licenceAnswersPage.emailValue, email)
 }
 

diff --git a/user-journey-tests/specs/finalAnswers.spec.js b/user-journey-tests/specs/finalAnswers.spec.js
@@ -82,8 +82,10 @@ const completeApplication = async () => {
 }
 
 describe('Check your final answers test', () => {
-  // eslint-disable-next-line
-  before('Navigate to check answers page', completeApplication)
+  beforeEach(async () => {
+    await browser.deleteAllCookies()
+    await completeApplication()
+  })
 
   it('Should verify the back link is history -1', async () => {
     await taskListPage.navigateToPageAndVerifyTitle()
@@ -148,7 +150,7 @@ describe('Check your final answers test', () => {
 
   it('Should verify the existing email and confirm resubmission', async () => {
     await finalAnswersPage.navigateToPageAndVerifyTitle()
-    validateAndAdjustEmail(
+    await validateAndAdjustEmail(
       finalAnswersPage.emailChange,
       finalAnswersPage.emailValue,
       emailDefault,
@@ -183,11 +185,6 @@ describe('Check your final answers test', () => {
   })
 
   describe('declarations', () => {
-    beforeEach(async () => {
-      await browser.deleteAllCookies()
-      await completeApplication()
-    })
-
     it('Should submit the page after selecting first declaration', async () => {
       await finalAnswersPage.navigateToPageAndVerifyTitle()
       await finalAnswersPage.selectADeclarationAndContinue()