Consistently use make_fake_X in tests and allow fields to be set to None in make_fakes
#1710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update tests to consistently use `make_fake_[model]` functions. Update use of these functions for the new argument structure. Fix various type and linting issues in `make_fakes`.
Fix intermittently failing test by increasing types of institutions tested in SourceListViewTest.test_ordering. Adjust expected ordering tuples to account for these institutions. Removes random assignment of a fake institutions `is_private_collector` field.
lucasmarchd01
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates tests to consistently use
make_fake_[model]functions. Updates use of these functions for the new argument structure.Fixes various type and linting issues in
make_fakes.Closes #1709.
Also fixes an intermittently-failing test (SourceListViewTest.test_ordering) caused by a case where multiple fake institutions had the same country. Refines the sorting function used to determine the expected order of fake sources in the test. Also modifies
make_fake_institutionto remove randomness: users of this function should now specify whether the institution has asiglumoris_private_collector.SourceListViewTest.test_orderingis updated to include a variety of different institutions/source combinations (sources with no holding institution, sources with private collector institutions, sources with the same institution, etc.).