Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Genre List: Remove Mass/Office column and change other column headers #1705

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

dchiller
Copy link
Contributor

Removes the "Mass/Office" column from the Genre List page and changes the other column headers (Genre -> Abbreviation and Description -> Genre). While I was modifying these headers, I went ahead and made them both sortable.

Also:

  • removes javascript for the page, which is no longer necessary given filters are gone.
  • formats the genre_list.html template.
  • updated tests to add testing for sorting functionality and remove testing for filtering functionality.

Closes #1590.

Screenshot of new Genre List page:

image

Also makes remaining columns sortable.

Removes `genre_list.js` which is no longer necessary with the removal of filtering by `Mass/Office`.

Updates tests.
@dchiller dchiller merged commit 0d2f8ab into DDMAL:develop Nov 22, 2024
1 check passed
@dchiller dchiller deleted the i1590-remove-mass-office-col branch November 22, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change table in genre list view: remove mass/office column and change other column headers
2 participants