Chant create: optimize suggested chants feature #1579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this change, we can make use of the python shell that runserver_plus provides when a python error occurs in django
Installs typing stubs for the requests package
…ture With a fix to the Cantus Index json-nextchants endpoint, we can now reduce the number of calls that need to be made to Cantus Index to support the suggested chants feature of the Chant Create page. All the data on the suggested chants that we need for the feature comes now in the result of that call and does not require additional json-cid calls.
…feature Additionally, cast the "count" attribute of the response to the json-nextchants endpoint to int.
|
Tests are currently failing because we install the "production" version on the test runner but use the development docker-compose file (which now requires a development dependency for the |
|
Ok, I think it makes the most sense to replicate the production environment on the test runner... so in that case we'll need to use a different command for the |
…go_tests Introduce a separate docker-compose file for use with the django_tests github action that replicates the production run environment (use of gunicorn rather than the django development server).
lucasmarchd01
approved these changes
Aug 7, 2024
67 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR eliminates all calls to the
json-cidendpoint for the "suggested chants" feature on the Chant Create view. All data required for the suggested chants is now supplied directly in the response to thejson-nextchantsendpoint.Given that we no longer need to make these extra calls, this PR also returns the number of suggested chants presented to at most 5 rather than at most 3.
Modifies tests and relevant mock data to conform to this change in endpoint behaviour.
In the process, adds a few development-related items:
runserver_plus. This server provides a shell for debugging any time a view errors -- a useful development feature.types-requestspackage with type stubs for therequestspackage.Closes #1424