[Issue-#186] - Fix - Windows issues on mox cli command and utils argparser #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `init.py`: windows error `(UnicodeEncodeError: 'charmap' codec can't encode character '\U0001f40d')` when the param `encoding="utf-8" for `open` is not set - `compile.py`: windows does not support `fork` method for `multiprocessing.set_start_method()`, hence changed to "spawn" - `vars.py`: added general constant `IS_WINDOWS` for future use and avoid any duplicates - fixed utils CLI command running an error when no arguments passed + fixed some var typo
s3bc40
changed the title
|
Supporting windows makes me nervous... I'd rather just not support it... but this feels benign... Tests look good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #186
init.py: Windows error(UnicodeEncodeError: 'charmap' codec can't encode character '\U0001f40d')when the paramencoding="utf-8" foropen` is not setcompile.py: Windows does not supportforkmethod formultiprocessing.set_start_method(), hence changed to "spawn"vars.py: added general constantIS_WINDOWSfor future use and avoid any duplicates