Add proper RobTop-like timestamps (configurable) #900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It keeps showing "52 years ago" on every comment on my gdps. |
|
Are you sure you didn't mess anything up? I tested code identical to this before and it had no issue |
|
🔥 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
meh it probably won't get merged
This PR adds in proper RobTop-like timestamps for messages, friend requests, level uploads, etc.
You can choose to use the old date formatting by going to config/timestamps.php and setting $timestampsMode to 1
On the technical side of stuff, I reworked the unused makeTime function inside incl/lib/mainLib.php which I assumed was made and then abandoned for the purpose of RobTop-like timestamps.
I also made some small styling changes like removing weird new line gaps or deleting commented out debugging code and added in some spaces between characters to make it more readable if you don't mind.