Set initial AUTO_INCREMENT value of level IDs to 128 #772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting the first level's ID to 128 (as is the case in real GD) avoids an issue which breaks stars for levels with really low IDs (I have no idea how the bug works)
|
Would you mind if inital ID of accountID be set to 71? Since that ID is hardcoded to have a cyan color comment. Also settings the song ID inital to 5000000 would be nice for songList.php. |
Actually never mind the song part, songList no longer only record songs with ID 5000000+ anymore, but it would still be nice to not clash with NG songs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting the first level's ID to 128 (as is the case in real GD) avoids an issue which breaks stars for levels with really low IDs (I have no idea how the bug works but I've heard it has something to do with clashing with official levels)