Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added ready conditions and updated conditions from creating to ready #3865

Merged
merged 1 commit into from
Mar 5, 2024
Merged

added ready conditions and updated conditions from creating to ready #3865

merged 1 commit into from
Mar 5, 2024

Conversation

ValClarkson
Copy link
Contributor

Issue:[PGO-920]

Checklist:

  • Have you added an explanation of what your changes do and why you'd like them to be included?
  • Have you updated or added documentation for the change, as applicable?
  • Have you tested your changes on all related environments with successful results, as applicable?
    • Have you added automated tests?

Type of Changes:

  • New feature
  • Bug fix
  • Documentation
  • Testing enhancement
  • Other

What is the current behavior (link to any open issues here)?

What is the new behavior (if this is a feature change)?

  • Breaking change (fix or feature that would cause existing functionality to change)

added ready conditions

Other Information:

@ValClarkson ValClarkson requested a review from dsessler7 March 4, 2024 23:10
@ValClarkson ValClarkson requested a review from dsessler7 March 5, 2024 19:52
dsessler7
dsessler7 requested changes Mar 5, 2024
View reviewed changes
Copy link
Contributor

@dsessler7 dsessler7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple small changes, but otherwise looks good.

internal/bridge/crunchybridgecluster/crunchybridgecluster_controller.go Outdated Show resolved Hide resolved
internal/bridge/crunchybridgecluster/crunchybridgecluster_controller.go Outdated Show resolved Hide resolved
@ValClarkson ValClarkson requested a review from dsessler7 March 5, 2024 21:24
@ValClarkson ValClarkson merged commit 7747ab7 into CrunchyData:master Mar 5, 2024
13 checks passed
@ValClarkson ValClarkson deleted the ready_conditions branch March 5, 2024 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsessler7 dsessler7 dsessler7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ValClarkson @dsessler7