-
Notifications
You must be signed in to change notification settings - Fork 602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade conditions #3861
Upgrade conditions #3861
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I think we want something similar to what Ben did on lines 259-274 in crunchybridgecluster_controller.go
where we check to see if an error condition is in place. If there is an error condition, we check the observed generation. If the observed generation hasn't changed, meaning the customer hasn't changed the spec, then we want to return early.
internal/bridge/crunchybridgecluster/crunchybridgecluster_controller.go
Outdated
Show resolved
Hide resolved
internal/bridge/crunchybridgecluster/crunchybridgecluster_controller.go
Outdated
Show resolved
Hide resolved
internal/bridge/crunchybridgecluster/crunchybridgecluster_controller.go
Outdated
Show resolved
Hide resolved
internal/bridge/crunchybridgecluster/crunchybridgecluster_controller.go
Outdated
Show resolved
Hide resolved
internal/bridge/crunchybridgecluster/crunchybridgecluster_controller.go
Outdated
Show resolved
Hide resolved
internal/bridge/crunchybridgecluster/crunchybridgecluster_controller.go
Outdated
Show resolved
Hide resolved
internal/bridge/crunchybridgecluster/crunchybridgecluster_controller.go
Outdated
Show resolved
Hide resolved
internal/bridge/crunchybridgecluster/crunchybridgecluster_controller.go
Outdated
Show resolved
Hide resolved
internal/bridge/crunchybridgecluster/crunchybridgecluster_controller.go
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple nitpicks, but looks good otherwise.
internal/bridge/crunchybridgecluster/crunchybridgecluster_controller.go
Outdated
Show resolved
Hide resolved
2815e41
to
02f21e5
Compare
Issue:[PGO-916]
spec is fixed. Also updated conditions
ce1dfd8
to
1682404
Compare
Checklist:
Type of Changes:
What is the current behavior (link to any open issues here)?
What is the new behavior (if this is a feature change)?
Added conditions for upgrading the cluster
Other Information: