Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade conditions #3861

Merged
merged 3 commits into from
Feb 29, 2024
Merged

Conversation

ValClarkson
Copy link
Contributor

Checklist:

  • Have you added an explanation of what your changes do and why you'd like them to be included?
  • Have you updated or added documentation for the change, as applicable?
  • Have you tested your changes on all related environments with successful results, as applicable?
    • Have you added automated tests?

Type of Changes:

  • [x ] New feature
  • Bug fix
  • Documentation
  • Testing enhancement
  • Other

What is the current behavior (link to any open issues here)?

What is the new behavior (if this is a feature change)?

  • Breaking change (fix or feature that would cause existing functionality to change)

Added conditions for upgrading the cluster

Other Information:

Copy link
Contributor

@dsessler7 dsessler7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I think we want something similar to what Ben did on lines 259-274 in crunchybridgecluster_controller.go where we check to see if an error condition is in place. If there is an error condition, we check the observed generation. If the observed generation hasn't changed, meaning the customer hasn't changed the spec, then we want to return early.

Copy link
Contributor

@dsessler7 dsessler7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple nitpicks, but looks good otherwise.

@ValClarkson ValClarkson merged commit f42fba6 into CrunchyData:master Feb 29, 2024
13 checks passed
@ValClarkson ValClarkson deleted the upgrade_conditions branch February 29, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants