Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pgAdmin RBAC to match feature requirements #3748

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Update pgAdmin RBAC to match feature requirements #3748

merged 1 commit into from
Oct 16, 2023

Conversation

tjmoore4
Copy link
Contributor

Checklist:

  • Have you added an explanation of what your changes do and why you'd like them to be included?
  • Have you updated or added documentation for the change, as applicable?
  • Have you tested your changes on all related environments with successful results, as applicable?
    • Have you added automated tests?

Type of Changes:

  • New feature
  • Bug fix
  • Documentation
  • Testing enhancement
  • Other

What is the new behavior (if this is a feature change)?

  • Breaking change (fix or feature that would cause existing functionality to change)
    Adjust kubebuilder markers and regenerate RBAC for current pgAdmin feature.

Other Information:
PGO-565

jmckulk
jmckulk approved these changes Oct 16, 2023
View reviewed changes
Copy link
Collaborator

@jmckulk jmckulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tjmoore4
Update pgAdmin RBAC to match feature requirements
1adefda 
Adjust kubebuilder markers and regenerate RBAC for current
pgAdmin feature.

PGO-565
@tjmoore4 tjmoore4 force-pushed the update-pgadmin-rbac branch from a85fa74 to 1adefda Compare October 16, 2023 15:13
@tjmoore4 tjmoore4 marked this pull request as ready for review October 16, 2023 15:56
@tjmoore4 tjmoore4 merged commit 400c101 into CrunchyData:master Oct 16, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbandy cbandy cbandy left review comments

@jmckulk jmckulk jmckulk approved these changes

@benjaminjb benjaminjb benjaminjb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tjmoore4 @cbandy @benjaminjb @jmckulk