Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Makefile to build docker plugin #47

Closed
wants to merge 1 commit into from

Conversation

davecramer
Copy link
Contributor

bring docker example run.sh up to date

fixes #43

bring docker example run.sh up to date
@Illydth
Copy link

Illydth commented May 15, 2018

@davecramer I assume this only brings the run.sh up to date to actually execute a docker plugin. As I don't see any code being put into docker.so in this PR, I assume that using "watch" without Kube or OpenShift is still a non-starter correct?

It's been a couple weeks since I was deep into this and at this point am unsure what I did with the existing code set I was working with to initially produce the problem reported in #43 so I'm trying to figure out if this PR actually fixes the issue that PGWatch used with docker SegFaults when run or if this PR actually does make watch functional in a normal docker/non kube environment?

Looking at the changes it doesn't look like it...

@abrightwell
Copy link
Member

@Illydth - you are correct. Until the docker plugin is implemented this project only supports failover in a kube/openshift environment. I've created issue #49 in the hopes that it will be completed in a future version. To avoid any obvious confusion, we should temporarily remove any references to docker until it is minimally supported.

@davecramer
Copy link
Contributor Author

We are of course encouraging Pull Requests!

@jmccormick2001
Copy link
Contributor

thanks, I think at this point I'll close this PR out since it doesn't really do much towards a Docker implementation, if someone wants to do a PR with the implementation I'll be happy to review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker Module not Built - Cannot Use without Kube
4 participants