Fix crystal v1.11 warnings for use of splat in macros.
#155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In `crystal v1.11.0` the use of the `splat (*)` operator in macro expressions was deprecated[1,2,3]. Instead it is recommended to use `.splat` instead. Currently, we are not building against `crystal v1.11`, however, we do want to move to it in near future. So here we're making these changes to get ahead of it. [1] https://crystal-lang.org/2024/01/08/1.11.0-released/ [2] https://github.com/crystal-lang/crystal/releases/tag/1.11.0 [3] crystal-lang/crystal#13939
ngaumont
approved these changes
Jan 31, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
crystal v1.11.0the use of thesplat (*)operator in macro expressions was deprecated[1,2,3]. Instead it is recommended to use.splatinstead. Currently, we are not building againstcrystal v1.11, however, we do want to move to it in near future. So here we're making these changes to get ahead of it.[1] https://crystal-lang.org/2024/01/08/1.11.0-released/
[2] https://github.com/crystal-lang/crystal/releases/tag/1.11.0
[3] crystal-lang/crystal#13939