Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable new github connections #2722

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

joanagmaia
Copy link
Contributor

@joanagmaia joanagmaia commented Dec 13, 2024

Changes proposed ✍️

What

copilot:summary

copilot:poem

Why

How

copilot:walkthrough

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screenshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

Summary by CodeRabbit

  • New Features

    • Introduced tooltips to inform users that onboarding new data for GitHub is currently disabled.
    • Updated button states to be disabled, preventing interaction for connecting to GitHub.
  • Bug Fixes

    • Replaced dynamic tooltip content with a static message regarding the disabled onboarding status.
  • Documentation

    • Enhanced user guidance by advising users to contact support for assistance with onboarding new data.

Copy link

coderabbitai bot commented Dec 13, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request introduces modifications to several Vue components related to GitHub integration. The github-connect.vue and github-settings-drawer.vue components have replaced their connection buttons with disabled versions wrapped in el-tooltip elements. These tooltips inform users that onboarding new data is currently disabled and direct them to contact support. The overall structure and functionality of the components remain unchanged, with no alterations to the logic handling connection processes.

Changes

File Path Change Summary
frontend/src/config/integrations/github/components/connect/github-connect.vue Replaced the connection button with a disabled button wrapped in an el-tooltip indicating onboarding is disabled.
frontend/src/config/integrations/github/components/github-connect.vue Modified the connection button to be disabled and wrapped in an el-tooltip with a message about onboarding being disabled.
frontend/src/config/integrations/github/components/settings/github-settings-drawer.vue Updated the tooltip content and set the button to always be disabled, preventing interaction while still calling the connect() method.

Possibly related PRs

  • Fix/repo remappings on fr #2718: This PR modifies the github-settings-drawer.vue component, which is also referenced in the main PR, focusing on the tooltip and disabled state of buttons related to GitHub onboarding, indicating a direct connection in the context of user interaction and messaging.

Poem

🐇 In the garden where GitHub blooms,
A tooltip whispers, dispelling glooms.
Buttons now rest, their tasks on hold,
"Contact support," the message bold.
Though onboarding's paused, we'll soon take flight,
With updates and changes, all will be right! 🌼


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a64e377 and 043db68.

📒 Files selected for processing (3)
  • frontend/src/config/integrations/github/components/connect/github-connect.vue (1 hunks)
  • frontend/src/config/integrations/github/components/github-connect.vue (1 hunks)
  • frontend/src/config/integrations/github/components/settings/github-settings-drawer.vue (1 hunks)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Experiment)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@joanagmaia joanagmaia merged commit 4421c01 into main Dec 13, 2024
5 of 6 checks passed
@joanagmaia joanagmaia deleted the hotfix/disable-new-github-connections branch December 13, 2024 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant